[ENH] Implemented a component for uploading and previewing the data table #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for staging-annotation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmanaem
added
the
pr-minor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 88.09% 80.48% -7.61%
==========================================
Files 12 17 +5
Lines 42 123 +81
Branches 7 17 +10
==========================================
+ Hits 37 99 +62
- Misses 5 24 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
surchs
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Hey @rmanaem, thanks a lot for the PR. Looks very good, really liking the UI!
I have to main asks:
- Let's split responsibility for upload and data between the components. Ideally this also means lifting the responsibility for parsing and restructuring the uploaded data out of the components and either into the store or into a dedicate function because that should facilitate testing a whole lot
- There is currently a bug where the datatable is not visible after navigating away from the upload page. I believe this bug will be both very obvious and very easy to fix once we do the concern split. But to be safe, let's include a test for it
- Implemented `FileUploader` and `DataTablePreview` components
|
Hey @surchs, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This section is for the PR reviewer
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see our Contributing Guidelines for more info)skip-release(to be applied by maintainers only)Closes #XXXXFor new features:
For bug fixes: